Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated to procedural test api #101

Merged
merged 11 commits into from
Sep 21, 2023
Merged

updated to procedural test api #101

merged 11 commits into from
Sep 21, 2023

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Sep 6, 2023 •
edited
Loading

This pr updates the existing interface tests to the new procedural API as implemented in canonical/pytest-interface-tester#7

@PietroPasotti PietroPasotti mentioned this pull request Sep 6, 2023
Merged
@PietroPasotti PietroPasotti changed the title updated to declarative test api updated to procedural test api Sep 6, 2023
gruyaume
gruyaume reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a note on improving the yaml spec

README_INTERFACE_TESTS.md Show resolved Hide resolved
README_INTERFACE_TESTS.md Show resolved Hide resolved
@PietroPasotti PietroPasotti mentioned this pull request Sep 18, 2023
Merged
@PietroPasotti
Copy link
Contributor Author

@gruyaume @simskij the CI is currently broken and this pr is the fix, see #104

@patriciareinoso patriciareinoso mentioned this pull request Sep 18, 2023
Merged
@patriciareinoso
Copy link
Contributor

Hi @simskij could you please review this PR. It's blocking 3 other PRs

@simskij simskij merged commit d5e5b55 into main Sep 21, 2023
6 checks passed
@simskij simskij deleted the declarative-api branch September 21, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

@simskij simskij simskij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PietroPasotti @patriciareinoso @simskij @gruyaume